Repository navigation
fix(gh-aw): create bootstrap candidate payload parent - #2131
Merged
Merged
Conversation
Part of #2128 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
🟡 Impact Analysis — PR #2131Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (4 files)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 3 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ✅ | CI passing | All checks passing |
Files Changed (5 files, +70 −4)
| File | +/− |
|---|---|
.changeset/bright-gh-aw-central-ops.md |
+1 −1 |
test/gh-aw-bootstrap-workflow.test.ts |
+64 −0 |
workflows/package/squad-bootstrap.md |
+1 −0 |
workflows/squad-bootstrap.md |
+1 −0 |
workflows/squad-workflows.manifest.json |
+3 −3 |
Total: +70 −4
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix preserves trust boundaries and includes mutation-proven compiled-workflow coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes bootstrap validation when the isolated candidate lacks the payload’s parent directory.
Changes:
- Creates the payload directory before writing.
- Adds mutation and compiled-artifact regression coverage.
- Regenerates packaged workflow integrity metadata.
| File | Description |
|---|---|
workflows/squad-bootstrap.md |
Creates the candidate payload parent. |
workflows/package/squad-bootstrap.md |
Regenerates the packaged workflow. |
workflows/squad-workflows.manifest.json |
Updates integrity digests. |
test/gh-aw-bootstrap-workflow.test.ts |
Covers directory creation, ordering, and provenance. |
.changeset/bright-gh-aw-central-ops.md |
Documents the bootstrap fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
15 of 17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitexclusion and bind provenance to the trusted checkout throughgitRootValidation
npm run gh-aw:integrity:check— passedCI=true npm run build— passednpm test -- test/gh-aw-bootstrap-workflow.test.ts test/gh-aw-cast-validator.test.ts test/gh-aw-quality.test.ts test/gh-aw-install-staging.test.ts test/gh-aw-review-workflow.test.ts test/gh-aw-review-guard.test.ts test/gh-aw-hosted-e2e.test.ts— passed (7 files, 762 tests)gh aw compile squad-bootstrap --strict --approve --no-check-update— passed (1 workflow, 0 warnings)gitRoot: checkoutretained,.gitexclusion retainedgit diff --check— passedPart of #2128